Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: net/quic/quic_ack_notifier_manager.cc

Issue 969443002: Deprecating FLAGS_quic_attach_ack_notifiers_to_packets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Remove_RevertRetransmissionTimeout_86651704
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_ack_notifier_manager.cc
diff --git a/net/quic/quic_ack_notifier_manager.cc b/net/quic/quic_ack_notifier_manager.cc
index 73e3c8e1c2ac87692fb8dc1e4256d95c67d7d9f8..cfdf8f90ffc9b8145fd4cb223144969106036219 100644
--- a/net/quic/quic_ack_notifier_manager.cc
+++ b/net/quic/quic_ack_notifier_manager.cc
@@ -76,43 +76,16 @@ void AckNotifierManager::OnPacketRetransmitted(
void AckNotifierManager::OnSerializedPacket(
const SerializedPacket& serialized_packet) {
- if (FLAGS_quic_attach_ack_notifiers_to_packets) {
- // Inform each attached AckNotifier of the packet's serialization.
- AckNotifierList& notifier_list =
- ack_notifier_map_[serialized_packet.sequence_number];
- for (QuicAckNotifier* notifier : serialized_packet.notifiers) {
- if (notifier == nullptr) {
- LOG(DFATAL) << "AckNotifier should not be nullptr.";
- continue;
- }
- notifier->OnSerializedPacket();
-
- // Update the mapping in the other direction, from sequence number to
- // AckNotifier.
- notifier_list.push_back(notifier);
- }
- } else {
- // AckNotifiers can only be attached to retransmittable frames.
- RetransmittableFrames* frames = serialized_packet.retransmittable_frames;
- if (frames == nullptr) {
- return;
- }
-
- // For each frame in |serialized_packet|, inform any attached AckNotifiers
- // of the packet's sequence number.
- for (const QuicFrame& quic_frame : frames->frames()) {
- if (quic_frame.type != STREAM_FRAME ||
- quic_frame.stream_frame->notifier == nullptr) {
- continue;
- }
-
- QuicAckNotifier* notifier = quic_frame.stream_frame->notifier;
- notifier->OnSerializedPacket();
-
- // Update the mapping in the other direction, from sequence number to
- // AckNotifier.
- ack_notifier_map_[serialized_packet.sequence_number].push_back(notifier);
+ // Inform each attached AckNotifier of the packet's serialization.
+ AckNotifierList& notifier_list =
+ ack_notifier_map_[serialized_packet.sequence_number];
+ for (QuicAckNotifier* notifier : serialized_packet.notifiers) {
+ if (notifier == nullptr) {
+ LOG(DFATAL) << "AckNotifier should not be nullptr.";
+ continue;
}
+ notifier->OnSerializedPacket();
+ notifier_list.push_back(notifier);
}
}
« no previous file with comments | « no previous file | net/quic/quic_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698