Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 969393004: Make net_utility_services depend on net_with_v8 instead of net. (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make net_utility_services depend on net_with_v8 instead of net. Without this, windows release builds will fail to link when this is added to the utility process build rule. BUG=11746 Committed: https://crrev.com/b91865cd50cb2c4be042178ca6c6a6448dde206b Cr-Commit-Position: refs/heads/master@{#319424}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/net.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Anand Mistry (off Chromium)
5 years, 9 months ago (2015-03-04 07:30:48 UTC) #2
eroman
lgtm
5 years, 9 months ago (2015-03-06 05:55:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969393004/1
5 years, 9 months ago (2015-03-06 06:10:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/2788) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-06 06:13:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969393004/20001
5 years, 9 months ago (2015-03-06 07:02:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 08:50:46 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 08:51:23 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b91865cd50cb2c4be042178ca6c6a6448dde206b
Cr-Commit-Position: refs/heads/master@{#319424}

Powered by Google App Engine
This is Rietveld 408576698