Missing named parameter.

pkg/compiler/lib/src/js/rewrite_async.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library rewrite_async;
 
 import "dart:math" show max;
 import 'dart:collection';
 
 import 'package:_internal/compiler/js_lib/shared/async_await_error_codes.dart'
@@ skipping 386 matching lines @@
   ///   where tempX is a fresh temporary variable.
   js.Expression _storeIfNecessary(js.Expression result) {
     // Note that RegExes, js.ArrayInitializer and js.ObjectInitializer are not
     // [js.Literal]s.
     if (result is js.Literal) return result;
     js.Expression tempVar = useTempVar(allocateTempVar());
     addStatement(js.js.statement('# = #;', [tempVar, result]));
     return tempVar;
   }
 
   withExpression(js.Expression node, fn(js.Expression result), {bool store}) {

[floitsch, 2015/03/03 13:40:41]

Please add documentation what it does. (and what the arguments do).

     int oldTempVarIndex = currentTempVarIndex;
     js.Expression visited = visitExpression(node);
     if (store) {
       visited = _storeIfNecessary(visited);
     }
     var result = fn(visited);
     currentTempVarIndex = oldTempVarIndex;
     return result;
   }
 
@@ skipping 406 matching lines @@
   @override
   void visitComment(js.Comment node) {
     addStatement(node);
   }
 
   @override
   js.Expression visitConditional(js.Conditional node) {
     if (!shouldTransform(node.then) && !shouldTransform(node.otherwise)) {
       return withExpression(node.condition, (js.Expression condition) {
         return js.js('# ? # : #', [condition, node.then, node.otherwise]);
-      });
+      }, store: false);
     }
     int thenLabel = newLabel("then");
     int joinLabel = newLabel("join");
     int elseLabel = newLabel("else");
     withExpression(node.condition, (js.Expression condition) {
       addStatement(js.js.statement('# = # ? # : #;',
           [goto, condition, js.number(thenLabel), js.number(elseLabel)]));
     }, store: false);
     addBreak();
     beginLabel(thenLabel);
@@ skipping 1606 matching lines @@
     return condition || body;
   }
 
   @override
   bool visitDartYield(js.DartYield node) {
     hasYield = true;
     visit(node.expression);
     return true;
   }
 }