[content]: Add CanExceedIdleDeadlineIfRequired function to RendererScheduler.

content/renderer/scheduler/renderer_scheduler_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_IMPL_H_
 #define CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_IMPL_H_
 
 #include "base/atomicops.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread_checker.h"
@@ skipping 23 matching lines @@
   scoped_refptr<base::SingleThreadTaskRunner> DefaultTaskRunner() override;
   scoped_refptr<base::SingleThreadTaskRunner> CompositorTaskRunner() override;
   scoped_refptr<SingleThreadIdleTaskRunner> IdleTaskRunner() override;
   scoped_refptr<base::SingleThreadTaskRunner> LoadingTaskRunner() override;
   void WillBeginFrame(const cc::BeginFrameArgs& args) override;
   void BeginFrameNotExpectedSoon() override;
   void DidCommitFrameToCompositor() override;
   void DidReceiveInputEventOnCompositorThread(
       const blink::WebInputEvent& web_input_event) override;
   void DidAnimateForInputOnCompositorThread() override;
+  bool CanExceedIdleDeadlineIfRequired() const override;
   bool IsHighPriorityWorkAnticipated() override;
   bool ShouldYieldForHighPriorityWork() override;
   void AddTaskObserver(base::MessageLoop::TaskObserver* task_observer) override;
   void RemoveTaskObserver(
       base::MessageLoop::TaskObserver* task_observer) override;
   void Shutdown() override;
 
   void SetTimeSourceForTesting(scoped_refptr<cc::TestNowSource> time_source);
   void SetWorkBatchSizeForTesting(size_t work_batch_size);
 
@@ skipping 17 matching lines @@
     COMPOSITOR_PRIORITY,
     TOUCHSTART_PRIORITY,
   };
 
   enum class InputStreamState {
     INACTIVE,
     ACTIVE,
     ACTIVE_AND_AWAITING_TOUCHSTART_RESPONSE
   };
 
+  enum class IdlePeriodState {
+    NOT_WITHIN_IDLE_PERIOD,
+    WITHIN_IDLE_PERIOD,
+    WITHIN_MAX_DEADLINE_IDLE_PERIOD
+  };
+
   class PollableNeedsUpdateFlag {
    public:
     PollableNeedsUpdateFlag(base::Lock* write_lock);
     ~PollableNeedsUpdateFlag();
 
     // Set the flag. May only be called if |write_lock| is held.
     void SetWhileLocked(bool value);
 
     // Returns true iff the flag is set to true.
     bool IsSet() const;
@@ skipping 53 matching lines @@
   Policy ComputeNewPolicy(base::TimeDelta* new_policy_duration);
 
   // An input event of some sort happened, the policy may need updating.
   void UpdateForInputEvent(blink::WebInputEvent::Type type);
 
   // Called when a previously queued input event was processed.
   // |begin_frame_time|, if non-zero, identifies the frame time at which the
   // input was processed.
   void DidProcessInputEvent(base::TimeTicks begin_frame_time);
 
-  // Returns true if we should initiate a long idle time now. Fills in
+  // Returns the new idle period state for the next long idle period. Fills in
   // |next_long_idle_period_delay_out| with the next time we should try to
   // initiate the next idle period.
-  bool ShouldStartLongIdlePeriod(
+  IdlePeriodState ComputeNewLongIdlePeriodState(
       const base::TimeTicks now,
-      base::TimeDelta* next_long_idle_period_delay_out);
+      base::TimeDelta* next_long_idle_period_delay);

[Sami, 2015/03/05 11:59:33]

Did you mean to drop the _out here? It's still referenced by the comment.

[rmcilroy, 2015/03/05 13:50:19]

opps no, thanks.

 
   // Initiate a long idle period.
   void InitiateLongIdlePeriod();
   void InitiateLongIdlePeriodAfterWakeup();
 
   // Start and end an idle period.
-  void StartIdlePeriod();
+  void StartIdlePeriod(IdlePeriodState new_idle_period_state);
   void EndIdlePeriod();
 
   base::TimeTicks Now() const;
 
   base::ThreadChecker main_thread_checker_;
   scoped_ptr<RendererTaskQueueSelector> renderer_task_queue_selector_;
   scoped_ptr<TaskQueueManager> task_queue_manager_;
   scoped_refptr<base::SingleThreadTaskRunner> control_task_runner_;
   scoped_refptr<base::SingleThreadTaskRunner> control_task_after_wakeup_runner_;
   scoped_refptr<base::SingleThreadTaskRunner> default_task_runner_;
   scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner_;
   scoped_refptr<base::SingleThreadTaskRunner> loading_task_runner_;
   scoped_refptr<SingleThreadIdleTaskRunner> idle_task_runner_;
 
   base::Closure update_policy_closure_;
   CancelableClosureHolder end_idle_period_closure_;
   CancelableClosureHolder initiate_next_long_idle_period_closure_;
   CancelableClosureHolder after_wakeup_initiate_next_long_idle_period_closure_;
 
   // Don't access current_policy_ directly, instead use SchedulerPolicy().
   Policy current_policy_;
-  bool in_idle_period_;
+  IdlePeriodState idle_period_state_;

[Sami, 2015/03/05 11:59:33]

Not initialized?

[rmcilroy, 2015/03/05 13:50:19]

Done.

 
   base::TimeTicks estimated_next_frame_begin_;
   base::TimeTicks current_policy_expiration_time_;
 
   // The incoming_signals_lock_ mutex protects access to all variables in the
   // (contiguous) block below.
   base::Lock incoming_signals_lock_;
   base::TimeTicks last_input_receipt_time_on_compositor_;
   base::TimeTicks last_input_process_time_on_main_;
   blink::WebInputEvent::Type last_input_type_;
   InputStreamState input_stream_state_;
   PollableNeedsUpdateFlag policy_may_need_update_;
 
   scoped_refptr<cc::TestNowSource> time_source_;
 
   base::WeakPtr<RendererSchedulerImpl> weak_renderer_scheduler_ptr_;
   base::WeakPtrFactory<RendererSchedulerImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RendererSchedulerImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_IMPL_H_