Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 969363002: Add [TypeChecking=Interface] to Element interface (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Interface] to Element interface This affects the generated code for the methods setAttributeNode() setAttributeNodeNS() removeAttributeNode() insertAdjacentElement() so that they now throw TypeError exceptions when called with invalid argument values. The implementations of each function contained code (removed here) that checked for invalid argument values and threw exceptions, so the only difference is the type of exception thrown (DOMException -> TypeError) except for insertAdjacentElement() that was already throwing TypeErrors. BUG=462561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/dynamic/insertAdjacentElement-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +0 lines, -15 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-03 11:27:23 UTC) #2
philipj_slow
lgtm
5 years, 9 months ago (2015-03-04 04:04:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969363002/1
5 years, 9 months ago (2015-03-04 04:05:53 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 06:35:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191256

Powered by Google App Engine
This is Rietveld 408576698