Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 969353003: Speed up identifier, keyword and smi parsing (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Speed up identifier, keyword and smi parsing BUG= Committed: https://crrev.com/a8b538ddf9342b368d9b5cc08a792e673ec4e414 Cr-Commit-Position: refs/heads/master@{#26962}

Patch Set 1 #

Patch Set 2 : Limit to ascii, ignore backslash #

Patch Set 3 : Use char predicates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -9 lines) Patch
M src/char-predicates.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/char-predicates-inl.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/scanner.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/scanner.cc View 1 2 4 chunks +58 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-03 12:12:29 UTC) #2
Yang
On 2015/03/03 12:12:29, Toon Verwaest wrote: > PTAL lgtm. clever :)
5 years, 9 months ago (2015-03-03 13:50:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969353003/40001
5 years, 9 months ago (2015-03-03 14:26:33 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-03 15:27:51 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 15:28:00 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a8b538ddf9342b368d9b5cc08a792e673ec4e414
Cr-Commit-Position: refs/heads/master@{#26962}

Powered by Google App Engine
This is Rietveld 408576698