Issue 96933004: Fix tag closing issues in the WebVTT tree builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 96933004: Fix tag closing issues in the WebVTT tree builder (Closed)

Created:
7 years ago by fs

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit), Nate Chapin, Mike West

CC:
blink-reviews, nessy, philipj_slow, gasubic, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix tag closing issues in the WebVTT tree builder An end tag </foo> that does not match the currently open element should be dropped. An exception to the above however, is the </ruby> end tag which also closes any currently open <rt>. BUG=321038 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162917

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -9 lines)			Patch
	M	LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/tree-building-expected.txt	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	Source/core/html/track/vtt/VTTParser.cpp	View		1 chunk	+22 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike West

Thanks for fixing this up. I like seeing test expectations go from FAIL to PASS. ...

7 years ago (2013-11-29 15:20:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/96933004/1

7 years ago (2013-11-29 15:36:22 UTC) #3

Message was sent while issue was closed.

Change committed as 162917

Expand Messages | Collapse Messages