Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 96933003: Simplify allocation tracker API (Closed)

Created:
7 years ago by yurys
Modified:
7 years ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Simplify allocation tracker API Deprecated separate methods for starting/stopping allocation tracking in favor of a bool param to Start/StopTrackingHeapObjects. BUG=None LOG=N R=loislo@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M include/v8-profiler.h View 2 chunks +9 lines, -3 lines 0 comments Download
src/api.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/heap-profiler.h View 2 chunks +1 line, -4 lines 0 comments Download
src/heap-profiler.cc View 3 chunks +11 lines, -16 lines 0 comments Download
M src/heap-snapshot-generator.h View 1 chunk +1 line, -1 line 0 comments Download
src/heap-snapshot-generator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +2 lines, -2 lines 0 comments Download
test/cctest/test-heap-profiler.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years ago (2013-11-29 13:23:01 UTC) #1
loislo
lgtm
7 years ago (2013-11-29 13:30:17 UTC) #2
Michael Starzinger
LGTM.
7 years ago (2013-12-02 14:05:34 UTC) #3
yurys
7 years ago (2013-12-02 14:27:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18197 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698