Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 969313002: Simplify GetPyProtoPath. (Closed)

Created:
5 years, 9 months ago by jam
Modified:
5 years, 9 months ago
Reviewers:
Chris Masone
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify GetPyProtoPath. We shouldn't hard code out/Release (since with GN the path could be different) or look for the checkout directory (since with swarming it doesn't exist). This was needed with ui_tests or pyauto, but not with the current browser_tests binaries. BUG=463180 Committed: https://crrev.com/35e1c076cbda56bd384f1b409f1bd782bd0fb70d Cr-Commit-Position: refs/heads/master@{#318892}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -48 lines) Patch
M net/test/python_utils.cc View 2 chunks +10 lines, -48 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jam
Chris: the CrOS tryrun is green. I noticed that sync_integration_tests doesn't run on the CrOS ...
5 years, 9 months ago (2015-03-03 06:33:49 UTC) #4
Chris Masone
I don't even remember writing this code, or what it was used for :-) LGTM, ...
5 years, 9 months ago (2015-03-03 15:19:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969313002/20001
5 years, 9 months ago (2015-03-03 15:29:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-03 16:37:08 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:38:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35e1c076cbda56bd384f1b409f1bd782bd0fb70d
Cr-Commit-Position: refs/heads/master@{#318892}

Powered by Google App Engine
This is Rietveld 408576698