Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 969293002: Ensure that the on screen keyboard detection on Windows 8+ is more reliable. (Closed)

Created:
5 years, 9 months ago by ananta
Modified:
5 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that the on screen keyboard detection on Windows 8+ is more reliable. The keyboard detection code is heuristic based as we don't have a reliable way to detect if a keyboard is attached. We use the Setup API's for keyboard class GUID's and look for specific prefixes in the device names like ACPI\PNP*, ACPI\MSF* and HID\VID*. If we find one of these we assume that a keyboard is present. Fixed a bug in the keyboard detection function where in the order of params for the StartsWith helper was flipped. This works on the Surface and Samsung touch screen laptops in my testing. BUG=335735 Committed: https://crrev.com/0bca9e9579ee5405f61eeb4eaafd125d19304c13 Cr-Commit-Position: refs/heads/master@{#318961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M base/win/win_util.cc View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ananta
5 years, 9 months ago (2015-03-03 04:10:32 UTC) #2
ananta
5 years, 9 months ago (2015-03-03 04:10:35 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-03 21:51:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969293002/1
5 years, 9 months ago (2015-03-03 21:52:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 23:20:59 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 23:23:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bca9e9579ee5405f61eeb4eaafd125d19304c13
Cr-Commit-Position: refs/heads/master@{#318961}

Powered by Google App Engine
This is Rietveld 408576698