Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 969283002: Instrument ExtensionToolbarModel::OnReady Codepaths to Find Jank (Closed)

Created:
5 years, 9 months ago by robliao
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrument ExtensionToolbarModel::OnReady Codepaths to Find Jank BUG=463337 Committed: https://crrev.com/59016318a0e9cb4860c31b0f10997f8d58355a94 Cr-Commit-Position: refs/heads/master@{#318984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M chrome/browser/extensions/extension_toolbar_model.cc View 2 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
robliao
kalman: Please provide owner approval for this mechanical instrumentation change. Thanks!
5 years, 9 months ago (2015-03-03 01:52:27 UTC) #2
not at google - send to devlin
lgtm, but +Devlin who will be able to help you track this down.
5 years, 9 months ago (2015-03-03 02:03:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969283002/1
5 years, 9 months ago (2015-03-03 21:27:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 00:54:49 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:55:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59016318a0e9cb4860c31b0f10997f8d58355a94
Cr-Commit-Position: refs/heads/master@{#318984}

Powered by Google App Engine
This is Rietveld 408576698