Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 969213002: Re-enable NewApi Android lint warning. (Closed)

Created:
5 years, 9 months ago by newt (away)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable NewApi Android lint warning. The NewApi warning complains when we use APIs added to Android after ICS because these will causes crashes on older versions of Android. This reenables this helpful warning and whitelists the files that currently trigger the warning. Follow-up CLs will fix these whitelisted warnings (i.e. by fixing the code if it's broken, or adding the @TargetApi annotation) BUG=266140 R=aurimas@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a928808ec67f1ddf41ba0643eec2611c9e6e4620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +41 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
newt (away)
PTAL
5 years, 9 months ago (2015-03-02 23:38:01 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 9 months ago (2015-03-03 00:25:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969213002/1
5 years, 9 months ago (2015-03-03 00:58:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/7690)
5 years, 9 months ago (2015-03-03 08:53:34 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a928808ec67f1ddf41ba0643eec2611c9e6e4620 Cr-Commit-Position: refs/heads/master@{#318942}
5 years, 9 months ago (2015-03-03 21:28:11 UTC) #8
newt (away)
5 years, 9 months ago (2015-03-03 21:28:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a928808ec67f1ddf41ba0643eec2611c9e6e4620 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698