Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: fpdfsdk/include/javascript/JS_Value.h

Issue 969203002: Merge to XFA: Kill off JS_ErrorString type. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/javascript/JS_Define.h ('k') | fpdfsdk/include/javascript/PublicMethods.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/javascript/JS_Value.h
diff --git a/fpdfsdk/include/javascript/JS_Value.h b/fpdfsdk/include/javascript/JS_Value.h
index e9faf32370ef3eb3bf3cbf0f8e90b2c3b67171cf..4962ddcf3dc81c9c22ce265b553aedf4dec3eb2c 100644
--- a/fpdfsdk/include/javascript/JS_Value.h
+++ b/fpdfsdk/include/javascript/JS_Value.h
@@ -73,13 +73,16 @@ protected:
v8::Isolate* m_isolate;
};
-template<class TYPE> class CJS_ParametersTmpl : public CFX_ArrayTemplate<TYPE>
+class CJS_Parameters : public CFX_ArrayTemplate<CJS_Value>
{
public:
- void push_back(TYPE newElement){CFX_ArrayTemplate<TYPE>::Add(newElement);}
- int size() const{return CFX_ArrayTemplate<TYPE>::GetSize();}
+ void push_back(const CJS_Value& newElement) {
+ CFX_ArrayTemplate<CJS_Value>::Add(newElement);
+ }
+ int size() const {
+ return CFX_ArrayTemplate<CJS_Value>::GetSize();
+ }
};
-typedef CJS_ParametersTmpl<CJS_Value> CJS_Parameters;
class CJS_PropValue: public CJS_Value
{
« no previous file with comments | « fpdfsdk/include/javascript/JS_Define.h ('k') | fpdfsdk/include/javascript/PublicMethods.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698