Issue 9692: * Fix bug in regexp parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9692: * Fix bug in regexp parser. (Closed)

Created:
12 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

Fixed bug in parsing of regexp character classes ([x-] didn't terminate correctly). Changed node-generation of look-aheads.

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -35 lines)			Patch
M	regexp2000/src/jsregexp.cc	View	1	7 chunks	+53 lines, -16 lines	0 comments	Download
M	regexp2000/src/parser.cc	View		1 chunk	+19 lines, -19 lines	0 comments	Download
M	regexp2000/test/cctest/test-regexp.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years, 1 month ago (2008-11-07 14:09:06 UTC) #2

Lgtm!

http://codereview.chromium.org/9692/diff/1/2
File regexp2000/src/jsregexp.cc (right):

http://codereview.chromium.org/9692/diff/1/2#newcode840
Line 840: result->data_.u_store_position.reg_ = reg;
Consider either adding an u_restore_position entry in data_ or rename
u_store_position to something more general that covers both uses.

http://codereview.chromium.org/9692/diff/1/2#newcode1003
Line 1003: out->stream()->Add("label=\"$pos=$%i\", shape=box",
I've been using ':=', not '='.

Expand Messages | Collapse Messages