Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 969123002: [Android] Fix partner customizations unit tests. (Closed)

Created:
5 years, 9 months ago by Kibeom Kim (inactive)
Modified:
5 years, 9 months ago
Reviewers:
aruslan, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix partner customizations unit tests. BUG=462838 Committed: https://crrev.com/61da6a9954e19f23c4ce8d752312b362b68198de Cr-Commit-Position: refs/heads/master@{#318781}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Kibeom Kim (inactive)
note: I don't have N5 right now, and on my N4, tests were passing locally ...
5 years, 9 months ago (2015-03-02 21:19:20 UTC) #2
newt (away)
lgtm https://codereview.chromium.org/969123002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java (right): https://codereview.chromium.org/969123002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java#newcode56 chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java:56: CommandLine.init(new String[]{}); FYI, you can pass null instead ...
5 years, 9 months ago (2015-03-02 21:31:50 UTC) #3
Kibeom Kim (inactive)
https://codereview.chromium.org/969123002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java (right): https://codereview.chromium.org/969123002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java#newcode56 chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java:56: CommandLine.init(new String[]{}); On 2015/03/02 21:31:50, newt wrote: > FYI, ...
5 years, 9 months ago (2015-03-02 21:47:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969123002/20001
5 years, 9 months ago (2015-03-02 21:48:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 22:38:45 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 22:40:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/61da6a9954e19f23c4ce8d752312b362b68198de
Cr-Commit-Position: refs/heads/master@{#318781}

Powered by Google App Engine
This is Rietveld 408576698