[Extensions] Expose enums on extension APIs.

extensions/renderer/resources/binding.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var Event = require('event_bindings').Event;
 var forEach = require('utils').forEach;
 var GetAvailability = requireNative('v8_context').GetAvailability;
 var exceptionHandler = require('uncaught_exception_handler');
 var lastError = require('lastError');
 var logActivity = requireNative('activityLogger');
@@ skipping 257 matching lines @@
     }
 
     var mod = {};
 
     var namespaces = $String.split(schema.namespace, '.');
     for (var index = 0, name; name = namespaces[index]; index++) {
       mod[name] = mod[name] || {};
       mod = mod[name];
     }
 
-    // Add types to global schemaValidator, the types we depend on from other
-    // namespaces will be added as needed.
     if (schema.types) {
       $Array.forEach(schema.types, function(t) {
         if (!isSchemaNodeSupported(t, platform, manifestVersion))
           return;
+
+        // Add types to global schemaValidator; the types we depend on from
+        // other namespaces will be added as needed.
         schemaUtils.schemaValidator.addTypes(t);
+
+        // Generate symbols for enums.
+        var enumValues = t['enum'];
+        if (enumValues) {
+          // Type IDs are qualified with the namespace during compilation,
+          // unfortunately, so remove it here.
+          logging.DCHECK(
+              t.id.substr(0, schema.namespace.length) == schema.namespace);
+          // Note: + 1 because it ends in a '.', e.g., 'fooApi.Type'.
+          var id = t.id.substr(schema.namespace.length + 1);
+          mod[id] = {};
+          $Array.forEach(enumValues, function(enumValue) {
+            enumValue = enumValue.name ? enumValue.name : enumValue;

[not at google - send to devlin, 2015/03/02 22:20:16]

// Note: enums can be declared either as a list of strings ['foo', 'bar'] or as
a list of objects [{'name': 'foo'}, {'name': 'bar'}].

[Devlin, 2015/03/02 23:32:35]

Done.

+            mod[id][enumValue] = enumValue;
+          });
+        }
       }, this);
     }
 
     // TODO(cduvall): Take out when all APIs have been converted to features.
     // Returns whether access to the content of a schema should be denied,
     // based on the presence of "unprivileged" and whether this is an
     // extension process (versus e.g. a content script).
     function isSchemaAccessAllowed(itemSchema) {
       return (contextType == 'BLESSED_EXTENSION') ||
              schema.unprivileged ||
@@ skipping 188 matching lines @@
                     availability.message);
       return;
     }
 
     this.runHooks_(mod);
     return mod;
   }
 };
 
 exports.Binding = Binding;