[Extensions] Expose enums on extension APIs.

[Extensions] Expose enums on extension APIs.

BUG=463184
Committed: https://crrev.com/2ba3c88d6b938211e66501fabbd3f6afcb1165b7
Cr-Commit-Position: refs/heads/master@{#318811}

[Devlin, 2015-03-02 19:59:09]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-03-02 19:59:23]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2015-03-02 22:20:16]

TY :-)

https://codereview.chromium.org/969063002/diff/20001/extensions/renderer/reso...
File extensions/renderer/resources/binding.js (right):

https://codereview.chromium.org/969063002/diff/20001/extensions/renderer/reso...
extensions/renderer/resources/binding.js:298: enumValue = enumValue.name ?
enumValue.name : enumValue;
// Note: enums can be declared either as a list of strings ['foo', 'bar'] or as
a list of objects [{'name': 'foo'}, {'name': 'bar'}].

[not at google - send to devlin, 2015-03-02 22:20:20]

The CQ bit was checked by kalman@chromium.org

[not at google - send to devlin, 2015-03-02 22:20:21]

lgtm

[not at google - send to devlin, 2015-03-02 22:20:25]

The CQ bit was unchecked by kalman@chromium.org

[not at google - send to devlin, 2015-03-02 22:22:52]

https://codereview.chromium.org/969063002/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/bindings/api_enums/background.js
(right):

https://codereview.chromium.org/969063002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/bindings/api_enums/background.js:37: 
Actually, one more test:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...
test empty string in webstorePrivate API.

[not at google - send to devlin, 2015-03-02 22:23:23]

On 2015/03/02 22:22:52, kalman wrote:
>
https://codereview.chromium.org/969063002/diff/20001/chrome/test/data/extensi...
> File chrome/test/data/extensions/api_test/bindings/api_enums/background.js
> (right):
> 
>
https://codereview.chromium.org/969063002/diff/20001/chrome/test/data/extensi...
> chrome/test/data/extensions/api_test/bindings/api_enums/background.js:37: 
> Actually, one more test:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...
> test empty string in webstorePrivate API.

I guess you'd need to load this test extension as a component extension to get
permission for that.

[Devlin, 2015-03-02 23:32:21]

On 2015/03/02 22:23:23, kalman wrote:
> On 2015/03/02 22:22:52, kalman wrote:
> >
>
https://codereview.chromium.org/969063002/diff/20001/chrome/test/data/extensi...
> > File chrome/test/data/extensions/api_test/bindings/api_enums/background.js
> > (right):
> > 
> >
>
https://codereview.chromium.org/969063002/diff/20001/chrome/test/data/extensi...
> > chrome/test/data/extensions/api_test/bindings/api_enums/background.js:37: 
> > Actually, one more test:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...
> > test empty string in webstorePrivate API.
> 
> I guess you'd need to load this test extension as a component extension to get
> permission for that.

As discussed offline, WebstorePrivate is kinda weird, so let's ignore it for
this first patch.

[Devlin, 2015-03-02 23:32:35]

https://codereview.chromium.org/969063002/diff/20001/extensions/renderer/reso...
File extensions/renderer/resources/binding.js (right):

https://codereview.chromium.org/969063002/diff/20001/extensions/renderer/reso...
extensions/renderer/resources/binding.js:298: enumValue = enumValue.name ?
enumValue.name : enumValue;
On 2015/03/02 22:20:16, kalman wrote:
> // Note: enums can be declared either as a list of strings ['foo', 'bar'] or
as
> a list of objects [{'name': 'foo'}, {'name': 'bar'}].

Done.

[Devlin, 2015-03-02 23:32:39]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-03-02 23:32:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/969063002/#ps40001 (title:
" ")

[commit-bot: I haz the power, 2015-03-02 23:33:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969063002/40001

[commit-bot: I haz the power, 2015-03-03 01:18:39]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-03 01:19:12]

Patchset 2 (id:??) landed as
https://crrev.com/2ba3c88d6b938211e66501fabbd3f6afcb1165b7
Cr-Commit-Position: refs/heads/master@{#318811}