Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 969053004: Remove unused ability to disable flow control in QUIC (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_CreateQuicConnection_method_86947282
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused ability to disable flow control in QUIC QuicFlowController::Disable() is no longer called. It was used when we disabled flow control for the headers and crypto streams, and for old versions which did not support connection level flow control. Now that we are on QUIC_VERSION_23, we now use flow control on all streams and all connections, so this is safe to remove. Thanks to tgreer@ for the scythe code removal in cl/86835556, and alyssar@ for noticing that the removal of the dead QuicFlowController:Disable() meant we could remove substantially more in this CL. Merge internal change: 86960342 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -92 lines) Patch
M net/quic/quic_crypto_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flow_controller.h View 2 chunks +0 lines, -9 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 9 chunks +1 line, -38 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_session.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 4 chunks +25 lines, -38 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-02 20:43:25 UTC) #1
Ryan Hamilton
5 years, 9 months ago (2015-03-03 05:01:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698