Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 969033004: Ensure initial state of javascript toggle is correct. (Closed)

Created:
5 years, 9 months ago by Finnur
Modified:
5 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure initial state of javascript toggle is correct. Fixes crash found when toggling the state. BUG=463062 Committed: https://crrev.com/5444415569f96d9e8c7a6224069560515f49aa91 Cr-Commit-Position: refs/heads/master@{#319099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Finnur
5 years, 9 months ago (2015-03-04 12:57:57 UTC) #2
newt (away)
lgtm
5 years, 9 months ago (2015-03-04 19:13:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969033004/1
5 years, 9 months ago (2015-03-04 19:14:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 19:19:40 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:21:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5444415569f96d9e8c7a6224069560515f49aa91
Cr-Commit-Position: refs/heads/master@{#319099}

Powered by Google App Engine
This is Rietveld 408576698