|
|
Chromium Code Reviews|
Created:
7 years ago by tfarina Modified:
7 years ago CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, iannucci Base URL:
https://chromium.googlesource.com/chromium/tools/commit-queue@master Visibility:
Public. |
DescriptionAdd google_apis_unittests to win bots.
See https://codereview.chromium.org/96943003
BUG=257421
R=stip@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=240845
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (0 generated)
https://chromiumcodereview.appspot.com/96903006/diff/1/projects.py File projects.py (right): https://chromiumcodereview.appspot.com/96903006/diff/1/projects.py#newcode390 projects.py:390: 'google_apis_unittests', I don't see this on the win_rel trybots, could you add that to https://chromiumcodereview.appspot.com/96943003/
https://chromiumcodereview.appspot.com/96903006/diff/1/projects.py File projects.py (right): https://chromiumcodereview.appspot.com/96903006/diff/1/projects.py#newcode390 projects.py:390: 'google_apis_unittests', On 2013/12/02 23:15:56, stip wrote: > I don't see this on the win_rel trybots, could you add that to > https://chromiumcodereview.appspot.com/96943003/ Done.
ping?
lgtm, but you'll need to wait on https://codereview.chromium.org/96943003/
Now that https://codereview.chromium.org/96943003/ was landed. This can be landed?
coordinate with the trooper to make sure this is synced up with CQ. note that the other CL is live at the moment (due to buildrunner)
Aaron, Robert, how can we coordinate landing this?
Vadmit, Scott, current sheriffs, can I land this?
On 2013/12/09 20:52:14, tfarina wrote: > Vadmit, Scott, current sheriffs, can I land this? Uh, sure? Is it going to break anything? :)
On 2013/12/09 20:53:20, scottmg wrote: > On 2013/12/09 20:52:14, tfarina wrote: > > Vadmit, Scott, current sheriffs, can I land this? > > Uh, sure? Is it going to break anything? :) What could break, right? I guess, can I take this as a green light?
On 2013/12/09 22:55:44, tfarina wrote: > On 2013/12/09 20:53:20, scottmg wrote: > > On 2013/12/09 20:52:14, tfarina wrote: > > > Vadmit, Scott, current sheriffs, can I land this? > > > > Uh, sure? Is it going to break anything? :) > > What could break, right? I guess, can I take this as a green light? Yes, go ahead. But this needs to have a master restart right? So I think you need to talk to szager who is the current trooper. Perhaps on irc would be easier than here.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/96903006/1
Message was sent while issue was closed.
Change committed as 240845
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
