Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 96903006: Add google_apis_unittests to win bots. (Closed)

Created:
7 years ago by tfarina
Modified:
7 years ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, iannucci
Base URL:
https://chromium.googlesource.com/chromium/tools/commit-queue@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M projects.py View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 16 (0 generated)
tfarina
7 years ago (2013-11-30 16:53:58 UTC) #1
tfarina
7 years ago (2013-11-30 16:53:58 UTC) #2
ghost stip (do not use)
https://chromiumcodereview.appspot.com/96903006/diff/1/projects.py File projects.py (right): https://chromiumcodereview.appspot.com/96903006/diff/1/projects.py#newcode390 projects.py:390: 'google_apis_unittests', I don't see this on the win_rel trybots, ...
7 years ago (2013-12-02 23:15:55 UTC) #3
tfarina
https://chromiumcodereview.appspot.com/96903006/diff/1/projects.py File projects.py (right): https://chromiumcodereview.appspot.com/96903006/diff/1/projects.py#newcode390 projects.py:390: 'google_apis_unittests', On 2013/12/02 23:15:56, stip wrote: > I don't ...
7 years ago (2013-12-03 21:59:29 UTC) #4
tfarina
ping?
7 years ago (2013-12-05 11:01:05 UTC) #5
ghost stip (do not use)
lgtm, but you'll need to wait on https://codereview.chromium.org/96943003/
7 years ago (2013-12-05 19:12:35 UTC) #6
tfarina
Now that https://codereview.chromium.org/96943003/ was landed. This can be landed?
7 years ago (2013-12-06 22:53:22 UTC) #7
ghost stip (do not use)
coordinate with the trooper to make sure this is synced up with CQ. note that ...
7 years ago (2013-12-06 23:06:59 UTC) #8
tfarina
Aaron, Robert, how can we coordinate landing this?
7 years ago (2013-12-07 15:47:46 UTC) #9
tfarina
Vadmit, Scott, current sheriffs, can I land this?
7 years ago (2013-12-09 20:52:14 UTC) #10
scottmg
On 2013/12/09 20:52:14, tfarina wrote: > Vadmit, Scott, current sheriffs, can I land this? Uh, ...
7 years ago (2013-12-09 20:53:20 UTC) #11
tfarina
On 2013/12/09 20:53:20, scottmg wrote: > On 2013/12/09 20:52:14, tfarina wrote: > > Vadmit, Scott, ...
7 years ago (2013-12-09 22:55:44 UTC) #12
scottmg
On 2013/12/09 22:55:44, tfarina wrote: > On 2013/12/09 20:53:20, scottmg wrote: > > On 2013/12/09 ...
7 years ago (2013-12-09 22:58:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/96903006/1
7 years ago (2013-12-14 02:32:12 UTC) #14
commit-bot: I haz the power
Change committed as 240845
7 years ago (2013-12-14 02:32:30 UTC) #15
LaciLeialoha
7 years ago (2013-12-14 02:38:59 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698