Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 9690: Rename codegen to macro-assembler.... (Closed)

Created:
12 years, 1 month ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Rename codegen to macro-assembler. Remove unneeded byte codes accidentally not removed after feedback from last review More tests. New instructions to check for end of input. Rename captures array to registers array. Committed: http://code.google.com/p/v8/source/detail?r=711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -294 lines) Patch
M src/SConscript View 1 chunk +2 lines, -2 lines 0 comments Download
M src/assembler-re2k.h View 4 chunks +8 lines, -6 lines 1 comment Download
M src/assembler-re2k.cc View 6 chunks +27 lines, -31 lines 0 comments Download
M src/assembler-re2k-inl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/bytecodes-re2k.h View 1 chunk +23 lines, -24 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter-re2k.cc View 5 chunks +64 lines, -70 lines 1 comment Download
D src/regexp-codegen.h View 1 chunk +0 lines, -115 lines 0 comments Download
D src/regexp-codegen-re2k.cc View 1 chunk +0 lines, -33 lines 0 comments Download
A + src/regexp-macro-assembler.h View 3 chunks +8 lines, -8 lines 0 comments Download
src/regexp-macro-assembler-re2k.h View 1 chunk +35 lines, -0 lines 0 comments Download
A + src/regexp-macro-assembler-re2k.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-regexp.cc View 2 chunks +83 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
12 years, 1 month ago (2008-11-07 10:27:39 UTC) #1
Lasse Reichstein
12 years, 1 month ago (2008-11-07 10:57:35 UTC) #2
The file src/regexp-macro-assembler-re2k.h was not added correctly (no A left of
it in the list). Sorry, this CL might fubar too.

Otherwise LGTM.

http://codereview.chromium.org/9690/diff/1/13
File src/assembler-re2k.h (right):

http://codereview.chromium.org/9690/diff/1/13#newcode47
Line 47: void Break();  // This insn will cause a fatal VM error if hit.
insn->instruction

http://codereview.chromium.org/9690/diff/1/12
File src/interpreter-re2k.cc (right):

http://codereview.chromium.org/9690/diff/1/12#newcode202
Line 202: UNREACHABLE();
Remember a "break;" after the last BYTECODE macro instance.

Powered by Google App Engine
This is Rietveld 408576698