Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 968993002: Fix for out-of-bounds intersection (found by fuzzer). (Closed)

Created:
5 years, 9 months ago by Stephen White
Modified:
5 years, 9 months ago
Reviewers:
egdaniel, egdaniel1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix for out-of-bounds intersection (found by fuzzer). Sometimes, the intersection returned by check_intersection() is out-of-bounds for both edges (above both tops or below both bottoms) due to floating-point inaccuracy. This causes split_edge() to create a tiny negative-length edge on one side (which would then assert). Although we could safely remove this assert and allow the negative length edge to be removed, it's faster/safer to simply avoid its creation in the first place by adjusting one edge to the other edge's endpoint. Added a new unit test to exercise this case. Committed: https://skia.googlesource.com/skia/+/a2b6d28755916cbb4817cd9d1cd1b0e237de9a50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +13 lines, -7 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Stephen White
Greg: PTAL. Thanks!
5 years, 9 months ago (2015-03-02 16:50:14 UTC) #2
egdaniel
lgtm
5 years, 9 months ago (2015-03-02 16:58:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968993002/1
5 years, 9 months ago (2015-03-02 17:28:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:34:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a2b6d28755916cbb4817cd9d1cd1b0e237de9a50

Powered by Google App Engine
This is Rietveld 408576698