Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 968943004: Move Android metrics files into a /metrics/ subfolder/package. (Closed)

Created:
5 years, 9 months ago by Yaron
Modified:
5 years, 9 months ago
CC:
chromium-reviews, gone
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Android metrics files into a /metrics/ subfolder/package. BUG=428903 Committed: https://crrev.com/8b96058b442231649934a8b7b7abdd48722434e9 Cr-Commit-Position: refs/heads/master@{#318782}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fix findbugs #

Patch Set 5 : finnicky findbugs? #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -332 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/UmaBridge.java View 1 1 chunk +0 lines, -107 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/UmaUtils.java View 2 1 chunk +2 lines, -44 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaBridge.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaUtils.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/nfc/BeamCallback.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/bandwidth/BandwidthReductionPreferences.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/bandwidth/DataReductionPromoScreen.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/android/chrome_main_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/android/metrics/uma_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/metrics/uma_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/android/metrics/uma_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/metrics/uma_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/android/uma_bridge.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/android/uma_bridge.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/android/uma_utils.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/android/uma_utils.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
Yaron
5 years, 9 months ago (2015-03-02 15:03:18 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 9 months ago (2015-03-02 16:34:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968943004/40001
5 years, 9 months ago (2015-03-02 16:55:13 UTC) #5
Yaron
+jbudorick for findbugs. It's completely temporary untilhttps://codereview.chromium.org/964363003/
5 years, 9 months ago (2015-03-02 17:53:34 UTC) #8
jbudorick
lgtm
5 years, 9 months ago (2015-03-02 17:56:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968943004/60001
5 years, 9 months ago (2015-03-02 18:00:31 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/52122)
5 years, 9 months ago (2015-03-02 19:43:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968943004/80001
5 years, 9 months ago (2015-03-02 20:40:13 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/43785)
5 years, 9 months ago (2015-03-02 20:44:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968943004/100001
5 years, 9 months ago (2015-03-02 21:12:13 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-03-02 22:39:24 UTC) #23
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 22:40:14 UTC) #24
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8b96058b442231649934a8b7b7abdd48722434e9
Cr-Commit-Position: refs/heads/master@{#318782}

Powered by Google App Engine
This is Rietveld 408576698