Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 968943002: check for null context on execution entry (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

check for null context on execution entry blink is incorrectly calling api functions without a context. we need this to find those places R=svenpanne@chromium.org BUG=v8:3929 LOG=y Committed: https://crrev.com/5f49fef32594090eec7fd1a1bb71c99f568c3622 Cr-Commit-Position: refs/heads/master@{#26943}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/api.cc View 1 2 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
lgtm
5 years, 9 months ago (2015-03-02 14:15:31 UTC) #2
dcarney
Committed patchset #3 (id:40001) manually as 5f49fef32594090eec7fd1a1bb71c99f568c3622 (presubmit successful).
5 years, 9 months ago (2015-03-02 14:17:29 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 14:17:30 UTC) #4
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f49fef32594090eec7fd1a1bb71c99f568c3622
Cr-Commit-Position: refs/heads/master@{#26943}

Powered by Google App Engine
This is Rietveld 408576698