Issue 968923005: Remove TCP and BBR's max congestion window. No practical change,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 968923005: Remove TCP and BBR's max congestion window. No practical change, (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@minor_simplification_PendingRetransmission_87254408

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove TCP and BBR's max congestion window. No practical change, because Chrome's receive window is the limiting factor. Adds kMaxReportedCwnd and kMaxReorderingForRtt as constants to replace the max CWND in classes that used to rely on max CWND. Merge internal change: 87346681 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -123 lines)			Patch
M	net/quic/congestion_control/send_algorithm_interface.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender.h	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender.cc	View	5 chunks	+14 lines, -22 lines	0 comments	Download
M	net/quic/congestion_control/tcp_cubic_sender_test.cc	View	6 chunks	+10 lines, -77 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	net/quic/quic_protocol.h	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.cc	View	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages