Use GetDisplayText() instead of text() for rendering text.

ui/gfx/render_text_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text_mac.h"
 
 #include <ApplicationServices/ApplicationServices.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 130 matching lines @@
   const void* values[] = { ct_font };
   base::ScopedCFTypeRef<CFDictionaryRef> attributes(
       CFDictionaryCreate(NULL,
                          keys,
                          values,
                          arraysize(keys),
                          NULL,
                          &kCFTypeDictionaryValueCallBacks));
 
   base::ScopedCFTypeRef<CFStringRef> cf_text(
-      base::SysUTF16ToCFStringRef(text()));
+      base::SysUTF16ToCFStringRef(GetDisplayText()));

[tapted, 2015/03/02 22:36:38]

This is one of the things I tried... unfortunately it wasn't enough to fix the
eliding problem.

(note RenderTextMac's override of GetDisplayText() is quite different to the one
in RenderTextHarfBuzz).

E.g. GetDisplayText() changes its return when the value of text_elided_ changes.
That happens in RenderText::UpdateDisplayText(), but UpdateDisplayText() doesn't
trigger a call to RenderTextMac::OnLayoutTextAttributeChanged(), so the
previously calculated runs are not invalidated.

[Jun Mukai, 2015/03/02 23:10:37]

I don't think RenderTextMac is quite different here, if elide_behavior is set,
display_text() and text_elided() should be updated properly in render_text.cc,
and this file seems to invoke UpdateDisplayText() properly.  If it doesn't
return elided text, that's a regression of RenderText.
Also, the new test case should catch the failure by checking the number of
glyphs in |line_|.

The test seems succeeding on the case, do you know what's wrong with my test
case?

   base::ScopedCFTypeRef<CFAttributedStringRef> attr_text(
       CFAttributedStringCreate(NULL, cf_text, attributes));
   base::ScopedCFTypeRef<CFMutableAttributedStringRef> attr_text_mutable(
       CFAttributedStringCreateMutableCopy(NULL, 0, attr_text));
 
   // TODO(asvitkine|msw): Respect GetTextDirection(), which may not match the
   // natural text direction. See kCTTypesetterOptionForcedEmbeddingLevel, etc.
 
   ApplyStyles(attr_text_mutable, ct_font);
   line_.reset(CTLineCreateWithAttributedString(attr_text_mutable));
@@ skipping 196 matching lines @@
     CTUnderlineStyle value = kCTUnderlineStyleNone;
     if (underline && CFNumberGetValue(underline, kCFNumberSInt32Type, &value))
       run->underline = (value == kCTUnderlineStyleSingle);
 
     run_origin.offset(run_width, 0);
   }
   runs_valid_ = true;
 }
 
 }  // namespace gfx