Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 968913002: [turbofan] Take type into account when determining Word32 phi representation. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Take type into account when determining Word32 phi representation. BUG= R=bmeurer@chromium.org Committed: https://crrev.com/d0b8839b35eaf43902699badf1f3919d370c5b38 Cr-Commit-Position: refs/heads/master@{#26958}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/compiler/simplified-lowering.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Jarin
Could you take a look, please?
5 years, 9 months ago (2015-03-02 12:51:43 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/968913002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/968913002/diff/1/src/compiler/simplified-lowering.cc#newcode456 src/compiler/simplified-lowering.cc:456: return (use & (kTypeNumber | kTypeAny)) != 0; Can ...
5 years, 9 months ago (2015-03-02 18:08:58 UTC) #2
Jarin
https://codereview.chromium.org/968913002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/968913002/diff/1/src/compiler/simplified-lowering.cc#newcode456 src/compiler/simplified-lowering.cc:456: return (use & (kTypeNumber | kTypeAny)) != 0; On ...
5 years, 9 months ago (2015-03-03 08:57:24 UTC) #3
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-03 09:16:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968913002/20001
5 years, 9 months ago (2015-03-03 12:01:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 12:23:14 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 12:23:29 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d0b8839b35eaf43902699badf1f3919d370c5b38
Cr-Commit-Position: refs/heads/master@{#26958}

Powered by Google App Engine
This is Rietveld 408576698