ash/test/ash_test_base.cc - Issue 968873005: Touch Feedback tests on Valgrind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/test/ash_test_base.cc

Issue 968873005: Touch Feedback tests on Valgrind (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update GestureConfiguration for AshTestBase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/test/ash_test_base.cc

diff --git a/ash/test/ash_test_base.cc b/ash/test/ash_test_base.cc

index 93b4b986929aa9012f9fe60effa11573e28140e6..c4be16ddb5cff7b92fd0e023385e483e9f666123 100644

--- a/ash/test/ash_test_base.cc

+++ b/ash/test/ash_test_base.cc

@@ -135,8 +135,11 @@ void AshTestBase::SetUp() {

ash::Shell::GetInstance()->cursor_manager()->EnableMouseEvents();

// Changing GestureConfiguration shouldn't make tests fail.

oshima 2015/03/09 22:55:56 nit: explanation why these values are necessary wo

jonross 2015/03/10 15:07:56 Done.

- ui::GestureConfiguration::GetInstance()

- ->set_max_touch_move_in_pixels_for_click(5);

+ ui::GestureConfiguration* gesture_config =

+ ui::GestureConfiguration::GetInstance();

+ gesture_config->set_max_touch_down_duration_for_click_in_ms(800);

+ gesture_config->set_long_press_time_in_ms(1000);

+ gesture_config->set_max_touch_move_in_pixels_for_click(5);

#if defined(OS_WIN)

if (!command_line->HasSwitch(ash::switches::kForceAshToDesktop)) {