Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 968793002: Handle wrongly formatted EXIF string field. (Closed)

Created:
5 years, 9 months ago by yawano
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle wrongly formatted EXIF string field. BUG=462521 TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ExifParser Committed: https://crrev.com/b74305ac60bfc66b49fb9b5ddc407ec8c44148c0 Cr-Commit-Position: refs/heads/master@{#318654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_jstest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js View 2 chunks +18 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/metadata/exif_parser_unittest.html View 1 chunk +20 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/metadata/exif_parser_unittest.js View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 9 months ago (2015-03-02 06:04:08 UTC) #2
hirono
LGTM, thanks!
5 years, 9 months ago (2015-03-02 06:18:58 UTC) #3
yawano
On 2015/03/02 06:18:58, hirono wrote: > LGTM, thanks! Thank you!
5 years, 9 months ago (2015-03-02 06:37:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968793002/1
5 years, 9 months ago (2015-03-02 06:38:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 06:40:51 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 06:41:32 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b74305ac60bfc66b49fb9b5ddc407ec8c44148c0
Cr-Commit-Position: refs/heads/master@{#318654}

Powered by Google App Engine
This is Rietveld 408576698