Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 968773004: [turbofan] Use the typer to statically detect Smis. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use the typer to statically detect Smis. R=rossberg@chromium.org Committed: https://crrev.com/5f3914fc195f922652d2408fe26a0baf5c21d150 Cr-Commit-Position: refs/heads/master@{#26939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -63 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +17 lines, -12 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +13 lines, -11 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +52 lines, -34 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-02 13:01:05 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-02 13:01:21 UTC) #2
rossberg
lgtm
5 years, 9 months ago (2015-03-02 13:07:09 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as 5f3914fc195f922652d2408fe26a0baf5c21d150 (presubmit successful).
5 years, 9 months ago (2015-03-02 13:10:48 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 13:10:53 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f3914fc195f922652d2408fe26a0baf5c21d150
Cr-Commit-Position: refs/heads/master@{#26939}

Powered by Google App Engine
This is Rietveld 408576698