Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: tools/perf/measurements/oilpan_gc_times.py

Issue 968773002: [Oilpan] Measure time for forced/idle GC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/oilpan_gc_times.py
diff --git a/tools/perf/measurements/oilpan_gc_times.py b/tools/perf/measurements/oilpan_gc_times.py
index 49e0a2e382c999880fb74c11ad414d30b31fb5a9..6a65ab56cfd708e5d9079504fddeed69cd956fd8 100644
--- a/tools/perf/measurements/oilpan_gc_times.py
+++ b/tools/perf/measurements/oilpan_gc_times.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import os
+import time
kouhei (in TOK) 2015/03/02 05:03:57 Remove.
peria 2015/03/02 05:27:58 Done.
from measurements import smoothness_controller
from measurements import timeline_controller
@@ -35,7 +36,6 @@ def _AddTracingResults(events, results):
# Parse in time line
gc_type = None
- forced = False
mark_time = 0
lazy_sweep_time = 0
complete_sweep_time = 0
@@ -45,13 +45,12 @@ def _AddTracingResults(events, results):
values['oilpan_coalesce'].append(duration)
continue
if event.name == 'Heap::collectGarbage':
- if not gc_type is None and not forced:
+ if not gc_type is None:
values['oilpan_%s_mark' % gc_type].append(mark_time)
values['oilpan_%s_lazy_sweep' % gc_type].append(lazy_sweep_time)
values['oilpan_%s_complete_sweep' % gc_type].append(complete_sweep_time)
gc_type = 'precise' if event.args['precise'] else 'conservative'
- forced = event.args['forced']
mark_time = duration
lazy_sweep_time = 0
complete_sweep_time = 0
@@ -63,7 +62,7 @@ def _AddTracingResults(events, results):
complete_sweep_time += duration
continue
- if not gc_type is None and not forced:
+ if not gc_type is None:
values['oilpan_%s_mark' % gc_type].append(mark_time)
values['oilpan_%s_lazy_sweep' % gc_type].append(lazy_sweep_time)
values['oilpan_%s_complete_sweep' % gc_type].append(complete_sweep_time)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698