Issue 968733002: Remove duplicate launcher page switching logic in AppListMainView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 968733002: Remove duplicate launcher page switching logic in AppListMainView. (Closed)

Created:
5 years, 9 months ago by calamity

Modified:
5 years, 9 months ago

Reviewers:
Matt Giuca

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_set_enabled

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove duplicate launcher page switching logic in AppListMainView. This CL removes duplicate logic from the AppListMainView as a follow up to https://codereview.chromium.org/958133005/. BUG=462444 Committed: https://crrev.com/baed24626d285501a80f2fab8272ce16271ed593 Cr-Commit-Position: refs/heads/master@{#319209}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -17 lines)			Patch
	M	ui/app_list/views/app_list_main_view.cc	View		2 chunks	+5 lines, -17 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968733002/1

5 years, 9 months ago (2015-03-05 02:14:55 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-05 03:54:49 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/baed24626d285501a80f2fab8272ce16271ed593
Cr-Commit-Position: refs/heads/master@{#319209}