Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 968683002: PDF: Switch some unit tests to higher level API. (Closed)

Created:
5 years, 9 months ago by hal.canary
Modified:
5 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

PDF: Switch some unit tests to higher level API. Also, clean up some headers. Committed: https://skia.googlesource.com/skia/+/3d32d50364d1b63777fbf05c3593a35601bde9e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -53 lines) Patch
M src/pdf/SkPDFBitmap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFCatalog.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/AnnotationTest.cpp View 3 chunks +14 lines, -21 lines 0 comments Download
M tests/CanvasTest.cpp View 2 chunks +9 lines, -13 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 3 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968683002/1
5 years, 9 months ago (2015-03-01 13:13:29 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-01 13:13:30 UTC) #3
hal.canary
ptal
5 years, 9 months ago (2015-03-01 13:55:37 UTC) #5
mtklein
lgtm
5 years, 9 months ago (2015-03-01 14:53:44 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 14:55:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3d32d50364d1b63777fbf05c3593a35601bde9e2

Powered by Google App Engine
This is Rietveld 408576698