Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 968653004: Revert of Remove dependency on //components/feedback on iOS (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove dependency on //components/feedback on iOS (patchset #1 id:1 of https://codereview.chromium.org/954943004/) Reason for revert: This CL cause the test to run in another order, causing a hidden dependency on the ordering to be visible. Reverting as this cause test failures. See http://crbug.com/462352 Original issue's description: > Remove dependency on //components/feedback on iOS > > iOS does not use //components/feedback to report feedback so remove > the unused dependencies. > > BUG=None > > Committed: https://crrev.com/3e96329f442c10d73174688a4786ab847a49a37f > Cr-Commit-Position: refs/heads/master@{#318211} TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/4fb46b5b522e018429b2e40cf5f1c037c3ebbe19 Cr-Commit-Position: refs/heads/master@{#318674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M chrome/browser/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +2 lines, -1 line 0 comments Download
M components/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M components/components.gyp View 1 chunk +5 lines, -1 line 0 comments Download
M components/components_tests.gyp View 6 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sdefresne
Created Revert of Remove dependency on //components/feedback on iOS
5 years, 9 months ago (2015-03-02 10:31:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968653004/1
5 years, 9 months ago (2015-03-02 10:32:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 10:33:15 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 10:33:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fb46b5b522e018429b2e40cf5f1c037c3ebbe19
Cr-Commit-Position: refs/heads/master@{#318674}

Powered by Google App Engine
This is Rietveld 408576698