Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: Source/core/page/PageLifecycleObserver.h

Issue 968633002: Simplify lifecycle notifiers and observers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/PageLifecycleObserver.h
diff --git a/Source/core/page/PageLifecycleObserver.h b/Source/core/page/PageLifecycleObserver.h
index e5d73b9572480b7415635e7edcf0fa941d18bcdd..50af252324fcfbc2b7aea4527cf547bb28b0c3df 100644
--- a/Source/core/page/PageLifecycleObserver.h
+++ b/Source/core/page/PageLifecycleObserver.h
@@ -33,19 +33,18 @@
namespace blink {
class LocalFrame;
+class PageLifecycleNotifier;
-template<> void observeContext(Page*, LifecycleObserver<Page>*);
-template<> void unobserveContext(Page*, LifecycleObserver<Page>*);
-
-class PageLifecycleObserver : public LifecycleObserver<Page> {
+class PageLifecycleObserver : public LifecycleObserver<Page, PageLifecycleObserver, PageLifecycleNotifier> {
public:
- explicit PageLifecycleObserver(Page*);
- virtual ~PageLifecycleObserver();
+ virtual void pageVisibilityChanged() { }
+ virtual void didCommitLoad(LocalFrame*) { }
Page* page() const;
- virtual void pageVisibilityChanged() { }
- virtual void didCommitLoad(LocalFrame*) { }
+protected:
+ explicit PageLifecycleObserver(Page*);
+ virtual ~PageLifecycleObserver();
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698