Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: Source/core/frame/DOMWindowLifecycleNotifier.h

Issue 968633002: Simplify lifecycle notifiers and observers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/DOMWindowLifecycleNotifier.h
diff --git a/Source/core/frame/DOMWindowLifecycleNotifier.h b/Source/core/frame/DOMWindowLifecycleNotifier.h
index 0dd1f6f3609a0b688c84011d74e78c357faea407..87cc766b515226edd2b76f5ef49e5d0c5da30d30 100644
--- a/Source/core/frame/DOMWindowLifecycleNotifier.h
+++ b/Source/core/frame/DOMWindowLifecycleNotifier.h
@@ -27,31 +27,24 @@
#define DOMWindowLifecycleNotifier_h
#include "platform/LifecycleNotifier.h"
-#include "wtf/HashSet.h"
-#include "wtf/PassOwnPtr.h"
-#include "wtf/TemporaryChange.h"
-#include "wtf/text/WTFString.h"
+#include "wtf/Forward.h"
namespace blink {
class DOMWindowLifecycleObserver;
class LocalDOMWindow;
-class DOMWindowLifecycleNotifier : public LifecycleNotifier<LocalDOMWindow> {
+class DOMWindowLifecycleNotifier : public LifecycleNotifier<LocalDOMWindow, DOMWindowLifecycleObserver> {
public:
+ void addObserver(DOMWindowLifecycleObserver*);
+ void removeObserver(DOMWindowLifecycleObserver*);
+
void notifyAddEventListener(LocalDOMWindow*, const AtomicString& eventType);
void notifyRemoveEventListener(LocalDOMWindow*, const AtomicString& eventType);
void notifyRemoveAllEventListeners(LocalDOMWindow*);
- virtual void addObserver(Observer*) override;
- virtual void removeObserver(Observer*) override;
-
protected:
explicit DOMWindowLifecycleNotifier(LocalDOMWindow*);
-
-private:
- typedef HashSet<DOMWindowLifecycleObserver*> DOMWindowObserverSet;
- DOMWindowObserverSet m_windowObservers;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698