Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Side by Side Diff: Source/core/dom/DocumentLifecycleNotifier.cpp

Issue 968633002: Simplify lifecycle notifiers and observers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All Rights Reserved. 2 * Copyright (C) 2013 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 10 matching lines...) Expand all
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "core/dom/DocumentLifecycleNotifier.h" 28 #include "core/dom/DocumentLifecycleNotifier.h"
29 29
30 #include "core/dom/DocumentLifecycleObserver.h" 30 #include "core/dom/DocumentLifecycleObserver.h"
31 #include "wtf/Assertions.h"
32 31
33 namespace blink { 32 namespace blink {
34 33
35 DocumentLifecycleNotifier::DocumentLifecycleNotifier(Document* document) 34 DocumentLifecycleNotifier::DocumentLifecycleNotifier(Document* document)
36 : LifecycleNotifier<Document>(document) 35 : LifecycleNotifier<Document, DocumentLifecycleObserver>(document)
37 { 36 {
38 } 37 }
39 38
40 void DocumentLifecycleNotifier::addObserver(DocumentLifecycleNotifier::Observer* observer) 39 void DocumentLifecycleNotifier::addObserver(DocumentLifecycleObserver* observer)
41 { 40 {
42 if (observer->observerType() == Observer::DocumentLifecycleObserverType) { 41 LifecycleNotifier<Document, DocumentLifecycleObserver>::addObserver(observer );
43 RELEASE_ASSERT(m_iterating != IteratingOverDocumentObservers);
44 m_documentObservers.add(static_cast<DocumentLifecycleObserver*>(observer ));
45 }
46
47 LifecycleNotifier<Document>::addObserver(observer);
48 } 42 }
49 43
50 void DocumentLifecycleNotifier::removeObserver(DocumentLifecycleNotifier::Observ er* observer) 44 void DocumentLifecycleNotifier::removeObserver(DocumentLifecycleObserver* observ er)
51 { 45 {
52 if (observer->observerType() == Observer::DocumentLifecycleObserverType) { 46 LifecycleNotifier<Document, DocumentLifecycleObserver>::removeObserver(obser ver);
53 RELEASE_ASSERT(m_iterating != IteratingOverDocumentObservers);
54 m_documentObservers.remove(static_cast<DocumentLifecycleObserver*>(obser ver));
55 }
56
57 LifecycleNotifier<Document>::removeObserver(observer);
58 } 47 }
59 48
60 void DocumentLifecycleNotifier::notifyDocumentWasDetached() 49 void DocumentLifecycleNotifier::notifyDocumentWasDetached()
61 { 50 {
62 TemporaryChange<IterationType> scope(m_iterating, IteratingOverDocumentObser vers); 51 TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
63 for (DocumentLifecycleObserver* observer : m_documentObservers) 52 for (DocumentLifecycleObserver* observer : m_observers)
64 observer->documentWasDetached(); 53 observer->documentWasDetached();
65 } 54 }
66 55
67 #if !ENABLE(OILPAN) 56 #if !ENABLE(OILPAN)
68 void DocumentLifecycleNotifier::notifyDocumentWasDisposed() 57 void DocumentLifecycleNotifier::notifyDocumentWasDisposed()
69 { 58 {
70 TemporaryChange<IterationType> scope(m_iterating, IteratingOverDocumentObser vers); 59 TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
71 for (DocumentLifecycleObserver* observer : m_documentObservers) 60 for (DocumentLifecycleObserver* observer : m_observers)
72 observer->documentWasDisposed(); 61 observer->documentWasDisposed();
73 } 62 }
74 #endif 63 #endif
75 64
76 } // namespace blink 65 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698