Simplify lifecycle notifiers and observers.

Source/core/dom/ContextLifecycleNotifier.h

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2013 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  *
  */
 
 #ifndef ContextLifecycleNotifier_h
 #define ContextLifecycleNotifier_h
 
 #include "platform/LifecycleNotifier.h"
 #include "wtf/HashSet.h"
-#include "wtf/PassOwnPtr.h"
 
 namespace blink {
 
 class ActiveDOMObject;
+class ContextLifecycleObserver;
 class ExecutionContext;
 
-class ContextLifecycleNotifier : public LifecycleNotifier<ExecutionContext> {
+class ContextLifecycleNotifier : public LifecycleNotifier<ExecutionContext, ContextLifecycleObserver> {
 public:
-    typedef HashSet<ActiveDOMObject*> ActiveDOMObjectSet;
-
-    const ActiveDOMObjectSet& activeDOMObjects() const { return m_activeDOMObjects; }
-
-    virtual void addObserver(Observer*) override;
-    virtual void removeObserver(Observer*) override;
+    void addObserver(ContextLifecycleObserver*);
+    void removeObserver(ContextLifecycleObserver*);
 
     void notifyResumingActiveDOMObjects();
     void notifySuspendingActiveDOMObjects();
     void notifyStoppingActiveDOMObjects();
 
+    using ActiveDOMObjectSet = HashSet<ActiveDOMObject*>;
+
+    const ActiveDOMObjectSet& activeDOMObjects() const { return m_activeDOMObjects; }

[haraken, 2015/03/01 09:18:39]

Why do we need to keep m_activeDOMObjects while we can remove other hash sets?

[sof, 2015/03/01 10:00:39]

We can remove it also if we accept iterating over the entire set of observers
when evaluating hasPendingActivity() -- there are a number of
non-ActiveDOMObject ExecutionContext observers -- which I didn't feel
comfortable doing right here. We can evaluate doing that in a followup?

[haraken, 2015/03/01 10:47:56]

Sure. Also I'm wondering if a right fix would be to move hasPendingActivity() to
ScriptWrappable because hasPendingActivity() is a way to keep wrappers alive.

[sof, 2015/03/01 17:21:37]

Once this change has proven itself and settled well, more can be done.

     bool contains(ActiveDOMObject* object) const { return m_activeDOMObjects.contains(object); }
     bool hasPendingActivity() const;
 
 protected:
     explicit ContextLifecycleNotifier(ExecutionContext*);
 
 private:
     ActiveDOMObjectSet m_activeDOMObjects;
 };
 
 } // namespace blink
 
 #endif // ContextLifecycleNotifier_h