bindings: Supports constructor attributes on prototype chains.

bindings: Supports constructor attributes on prototype chains.

Supports constructor attributes on prototype chains.

- No one needs {{cpp_class}}ForceSetAttributeOnThisCallback.
- {{cpp_class}}ConstructorGetter does NOT depend on {{cpp_class}} or
  {{attribute}}.  Moved out to
  v8ConstructorAttributeGetterAs{Property,Accessor} in V8Binding.h.

BUG=43394
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191179

[Yuki, 2015-02-28 09:57:27]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2015-02-28 09:57:27]

Could you review this CL?

[haraken, 2015-02-28 15:19:16]

LGTM

https://codereview.chromium.org/968593002/diff/1/Source/bindings/core/v8/V8Bi...
File Source/bindings/core/v8/V8Binding.h (right):

https://codereview.chromium.org/968593002/diff/1/Source/bindings/core/v8/V8Bi...
Source/bindings/core/v8/V8Binding.h:1015: void
v8ConstructorAttributeGetterAsProperty(v8::Local<v8::String> propertyName, const
v8::PropertyCallbackInfo<v8::Value>&);

Can we use template to unify these two functions? Then we can have
v8ConstructorAttributeGetter() only.

[Yuki, 2015-03-03 07:03:53]

https://codereview.chromium.org/968593002/diff/1/Source/bindings/core/v8/V8Bi...
File Source/bindings/core/v8/V8Binding.h (right):

https://codereview.chromium.org/968593002/diff/1/Source/bindings/core/v8/V8Bi...
Source/bindings/core/v8/V8Binding.h:1015: void
v8ConstructorAttributeGetterAsProperty(v8::Local<v8::String> propertyName, const
v8::PropertyCallbackInfo<v8::Value>&);
On 2015/02/28 15:19:15, haraken wrote:
> 
> Can we use template to unify these two functions? Then we can have
> v8ConstructorAttributeGetter() only.

Yes, it's possible.
However, as we talked offline, it's better to use non template functions when we
store the address of functions because it's clearer which version of functions
is referenced.  e.g.

const V8DOMConfiguration& attributeConfiguration = {
  v8ConstructorAttributeGetterAsProperty, ... };

[Yuki, 2015-03-03 07:03:57]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2015-03-03 07:04:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/968593002/1

[commit-bot: I haz the power, 2015-03-03 08:32:59]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191179