Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 968573002: Revert of Revert of Add a new enable_nonblocking_io field trial param for QUIC (Closed)

Created:
5 years, 9 months ago by qyearsley
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Alpha Left Google
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Add a new enable_nonblocking_io field trial param for QUIC (patchset #1 id:1 of https://codereview.chromium.org/970513004/) Reason for revert: Revert apparently didn't help, still failing: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/39616 Original issue's description: > Revert of Add a new enable_nonblocking_io field trial param for QUIC (patchset #6 id:120001 of https://codereview.chromium.org/938003003/) > > Reason for revert: > Speculative revert to see whether this affects some tests that involve loading fonts in gfx_unittests (see failures at http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29). > > Original issue's description: > > Add a new enable_nonblocking_io field trial param for QUIC which enables the new non-blocking IO support on windows. > > > > BUG=442392 > > > > Committed: https://crrev.com/83e8c1477cf5d41928b8c9035f0c4812828752f4 > > Cr-Commit-Position: refs/heads/master@{#318555} > > TBR=rtenneti@chromium.org,rch@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=442392 > > Committed: https://crrev.com/369bca8b735e6275616052b9b9e3755f3305eb1f > Cr-Commit-Position: refs/heads/master@{#318601} TBR=rtenneti@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=442392 Committed: https://crrev.com/3257b7de61c3c45782dc9af6d235f55f8b8e40fe Cr-Commit-Position: refs/heads/master@{#318602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_session.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 4 chunks +10 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qyearsley
Created Revert of Revert of Add a new enable_nonblocking_io field trial param for QUIC
5 years, 9 months ago (2015-02-28 06:57:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968573002/1
5 years, 9 months ago (2015-02-28 06:58:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 06:59:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3257b7de61c3c45782dc9af6d235f55f8b8e40fe Cr-Commit-Position: refs/heads/master@{#318602}
5 years, 9 months ago (2015-02-28 06:59:54 UTC) #4
ramant (doing other things)
5 years, 9 months ago (2015-03-01 02:01:35 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698