Issue 968553002: Attempt to fix the build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 968553002: Attempt to fix the build (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
hansmuller

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Attempt to fix the build This CL attempts to fix clean builds by adding a missing dependency from service_registry to service_provider. Also, I've attempted to fix the sky tests by updating the reference to service_registry.mojom.dart. TBR=hansmuller@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d710804614f024b9ed353e6bd1c3ad6fef691d04

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	mojo/services/service_registry/public/interfaces/BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	sky/framework/embedder.dart	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 9 months ago (2015-02-28 04:13:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d710804614f024b9ed353e6bd1c3ad6fef691d04 (presubmit successful).

Expand Messages | Collapse Messages