Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 96853003: Drop IsPregenerated() and allow_stub_calls flag. (Closed)

Created:
7 years ago by Benedikt Meurer
Modified:
7 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Drop IsPregenerated() and allow_stub_calls flag. This also removes the fixed register hack that was required to support RecordWriteStub in the snapshot. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18167

Patch Set 1 #

Patch Set 2 : Also ditch the fixed register hack that was required for RecordWriteStub. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -417 lines) Patch
M src/arm/code-stubs-arm.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 5 chunks +0 lines, -99 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 3 chunks +1 line, -5 lines 0 comments Download
M src/code-stubs.h View 8 chunks +0 lines, -41 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 4 chunks +0 lines, -88 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +1 line, -5 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 4 chunks +0 lines, -93 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 6 chunks +5 lines, -22 lines 0 comments Download
M test/cctest/test-code-stubs-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-code-stubs-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-code-stubs-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 33 chunks +10 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Michi, You'll love this one. :-) PTAL -- Benedikt
7 years ago (2013-11-29 13:37:31 UTC) #1
Michael Starzinger
LGTM. Love it!
7 years ago (2013-11-29 14:45:41 UTC) #2
Benedikt Meurer
7 years ago (2013-11-29 20:49:28 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r18167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698