Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: net/quic/quic_connection.h

Issue 968513002: Land Recent QUIC Changes until 2/21/2015. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed const from members of TransmissionInfo struct. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_client_session.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index e944aea51951a473b7b1dafc5f6bc21e86a2dbb2..789a7e52e0ed80bbf24295a48bd65bac32c25200 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -387,9 +387,8 @@ class NET_EXPORT_PRIVATE QuicConnection
void set_visitor(QuicConnectionVisitorInterface* visitor) {
visitor_ = visitor;
}
- // This method takes ownership of |debug_visitor|.
void set_debug_visitor(QuicConnectionDebugVisitor* debug_visitor) {
- debug_visitor_.reset(debug_visitor);
+ debug_visitor_ = debug_visitor;
packet_generator_.set_debug_delegate(debug_visitor);
sent_packet_manager_.set_debug_delegate(debug_visitor);
}
@@ -768,8 +767,10 @@ class NET_EXPORT_PRIVATE QuicConnection
// An alarm that fires when a ping should be sent.
scoped_ptr<QuicAlarm> ping_alarm_;
+ // Neither visitor is owned by this class.
QuicConnectionVisitorInterface* visitor_;
- scoped_ptr<QuicConnectionDebugVisitor> debug_visitor_;
+ QuicConnectionDebugVisitor* debug_visitor_;
+
QuicPacketGenerator packet_generator_;
// An alarm that fires when an FEC packet should be sent.
« no previous file with comments | « net/quic/quic_client_session.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698