Land Recent QUIC Changes until 2/21/2015.

Land Recent QUIC Changes until 2/21/2015.

QUIC - use a range-based for loops. Sync'ing with the internal tree.

Merge internal change: 86845495
https://codereview.chromium.org/963333002/

Deprecate FLAGS_quic_record_send_time_before_write.

Merge internal change: 86804950
https://codereview.chromium.org/965873004/

QuicConnection no longer owns the debug visitor. No behavior change.

The visitor_ isn't owned by the connection, this makes the
debug_visitor_ ownership model the same.

Merge internal change: 86801250
https://codereview.chromium.org/961173003/

Cleanup of QUIC's TransmissionInfo constructor to make more fields const
and supply them in the constructor.  No functional change.

Merge internal change: 86734009
https://codereview.chromium.org/968493002/

Fixing a bug in the QUIC prober where if we received a GOAWAY before
stream creation it would result in a crash.

I verified that given our improper client, the prober would crash
as-was, and would fail cleanly with the nullptr check but the client not
ignoring goaways.

Test changes and quic server changes.

Merge internal change: 86703503
https://codereview.chromium.org/965943002/

Remove dead method QuicUnackedPacketMap::RestoreInFlight.

Merge internal change: 86690324
https://codereview.chromium.org/960913004/

Deprecating FLAGS_quic_attach_ack_notifiers_to_packets.

Merge internal change: 86688595
https://codereview.chromium.org/969443002/

Remove RevertRetransmissionTimeout from QUIC's SendAlgorithmInterface
now that it's no longer used by QuicSentPacketManager.

Merge internal change: 86651704
https://codereview.chromium.org/963293002/

Remove stats for recording reno vs cubic mode in internal server's varz.

Removed now that we know how much cubic mode is in play.

Merge internal change: 86629919
https://codereview.chromium.org/964483005/

R=rch@chromium.org

Committed: https://crrev.com/3183ac4cda7d296f8f59a658a1aca3ed961d76f3
Cr-Commit-Position: refs/heads/master@{#318588}

[Ryan Hamilton, 2015-02-28 00:50:00]

On 2015/02/28 00:23:25, ramant wrote:

One you merge the changes from https://codereview.chromium.org/961173003/ into
this CL, it LGTM.

[ramant (doing other things), 2015-02-28 01:05:05]

On 2015/02/28 00:50:00, Ryan Hamilton wrote:
> On 2015/02/28 00:23:25, ramant wrote:
> 
> One you merge the changes from https://codereview.chromium.org/961173003/ into
> this CL, it LGTM.

Merged quic_client_session*.* changes.

Thanks much Ryan,
raman

[ramant (doing other things), 2015-02-28 01:06:44]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2015-02-28 01:06:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/968513002/#ps20001 (title:
"Fixed QuicClientSession to use a scoped_ptr - merging change from 961173003")

[commit-bot: I haz the power, 2015-02-28 01:07:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/968513002/20001

[commit-bot: I haz the power, 2015-02-28 01:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-28 01:44:22]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[ramant (doing other things), 2015-02-28 02:40:55]

Removed const from members of TransmissionInfo struct to fix compile errors
(blessed by ianswett).

[ramant (doing other things), 2015-02-28 02:41:35]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2015-02-28 02:41:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/968513002/#ps40001 (title:
"Removed const from members of TransmissionInfo struct.")

[commit-bot: I haz the power, 2015-02-28 02:42:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/968513002/40001

[Ian Swett, 2015-02-28 02:51:46]

ianswett@google.com changed reviewers:
+ ianswett@google.com

[Ian Swett, 2015-02-28 02:51:47]

lgtm

Thanks Raman, LGTM.

[commit-bot: I haz the power, 2015-02-28 03:39:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-28 03:42:20]

Patchset 3 (id:??) landed as
https://crrev.com/3183ac4cda7d296f8f59a658a1aca3ed961d76f3
Cr-Commit-Position: refs/heads/master@{#318588}