Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 968493004: Moved service_registry from services to mojo/services/service_registry (Closed)

Created:
5 years, 9 months ago by hansmuller
Modified:
5 years, 9 months ago
Reviewers:
tonyg, hansmuller1, sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Moved service_registry from services to mojo/services/service_registry It needs to be in a conventional public location to be available to consumer repos. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5403b15ebdcc4b326437fcf85036953f3c6825c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -32 lines) Patch
M mojo/services/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/services/service_registry/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/service_registry/public/interfaces/service_registry.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D services/service_registry/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D services/service_registry/service_registry.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
hansmuller1
PTAL
5 years, 9 months ago (2015-02-28 00:21:29 UTC) #3
tonyg
If tests are happy, this lgtm
5 years, 9 months ago (2015-02-28 00:33:51 UTC) #5
hansmuller
5 years, 9 months ago (2015-02-28 00:36:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5403b15ebdcc4b326437fcf85036953f3c6825c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698