Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tools/telemetry/telemetry/unittest_util/run_tests.py

Issue 968493003: [Telemetry] Skip disabled Tests when filtering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/unittest_util/run_tests.py
diff --git a/tools/telemetry/telemetry/unittest_util/run_tests.py b/tools/telemetry/telemetry/unittest_util/run_tests.py
index 8539e5d341ea5ce7f753d592d421ef2778268899..b4f6b8db5ce53448c25c652e0831ba152be52cb7 100644
--- a/tools/telemetry/telemetry/unittest_util/run_tests.py
+++ b/tools/telemetry/telemetry/unittest_util/run_tests.py
@@ -141,16 +141,9 @@ class RunTestsCommand(command_line.OptparseCommand):
def GetClassifier(args, possible_browser):
def ClassifyTest(test_set, test):
name = test.id()
- if args.positional_args:
- if _MatchesSelectedTest(name, args.positional_args,
- args.exact_test_filter):
- assert hasattr(test, '_testMethodName')
- method = getattr(test, test._testMethodName) # pylint: disable=W0212
- if decorators.ShouldBeIsolated(method, possible_browser):
- test_set.isolated_tests.append(typ.TestInput(name))
- else:
- test_set.parallel_tests.append(typ.TestInput(name))
- else:
+ if (not args.positional_args
+ or _MatchesSelectedTest(name, args.positional_args,
+ args.exact_test_filter)):
assert hasattr(test, '_testMethodName')
method = getattr(test, test._testMethodName) # pylint: disable=W0212
should_skip, reason = decorators.ShouldSkip(method, possible_browser)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698