Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: lib/src/report.dart

Issue 968483002: Fix reporter (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/report.dart
diff --git a/lib/src/report.dart b/lib/src/report.dart
index 723ed810aa4ca6960f605815b6791469db9791ac..62a0a5f166d49e05215a888917c6570f8b03e20a 100644
--- a/lib/src/report.dart
+++ b/lib/src/report.dart
@@ -78,26 +78,27 @@ class SummaryReporter implements CheckerReporter {
SourceFile _file;
void enterLibrary(LibraryInfo lib) {
- var libSummary = _currentLibrary = new LibrarySummary(lib.name);
+ var libKey = '${lib.library.source.uri}';
+ var libSummary = _currentLibrary = new LibrarySummary(libKey);
var uri = lib.library.source.uri;
if (uri.scheme == 'package') {
var pname = path.split(uri.path)[0];
result.packages.putIfAbsent(pname, () => new PackageSummary(pname));
- if (result.packages[pname].libraries[lib.name] != null) {
- print('ERROR: duplicate ${lib.name}');
+ if (result.packages[pname].libraries[libKey] != null) {
+ print('ERROR: duplicate ${libKey}');
}
- result.packages[pname].libraries[lib.name] = libSummary;
+ result.packages[pname].libraries[libKey] = libSummary;
} else if (uri.scheme == 'dart') {
- if (result.system[lib.name] != null) {
- print('ERROR: duplicate ${lib.name}');
+ if (result.system[libKey] != null) {
+ print('ERROR: duplicate ${libKey}');
}
- result.system[lib.name] = libSummary;
+ result.system[libKey] = libSummary;
} else {
- if (result.loose[lib.name] != null) {
- print('ERROR: duplicate ${lib.name}');
+ if (result.loose[libKey] != null) {
+ print('ERROR: duplicate ${libKey}');
}
- result.loose[lib.name] = libSummary;
+ result.loose[libKey] = libSummary;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698