Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 968383002: Remove deprecated constructors from enhanced bookmark model (Closed)

Created:
5 years, 9 months ago by Ian Wen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated constructors from enhanced bookmark model EnhancedBookmarksModel(int) is never used and should be removed. BUG=458632 Committed: https://crrev.com/a58d0f0c1b3002335aa5852c4656cff05dfc9b01 Cr-Commit-Position: refs/heads/master@{#318907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ian Wen
5 years, 9 months ago (2015-03-02 23:07:18 UTC) #2
Kibeom Kim (inactive)
lgtm
5 years, 9 months ago (2015-03-02 23:53:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968383002/1
5 years, 9 months ago (2015-03-03 00:00:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/29410)
5 years, 9 months ago (2015-03-03 02:11:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968383002/1
5 years, 9 months ago (2015-03-03 17:46:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 18:08:21 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 18:08:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a58d0f0c1b3002335aa5852c4656cff05dfc9b01
Cr-Commit-Position: refs/heads/master@{#318907}

Powered by Google App Engine
This is Rietveld 408576698