ui/events/devices/x11/touch_factory_x11.cc - Issue 968343002: Make the native select menu work on Linux touch screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/devices/x11/touch_factory_x11.cc

Issue 968343002: Make the native select menu work on Linux touch screen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/devices/x11/touch_factory_x11.cc

diff --git a/ui/events/devices/x11/touch_factory_x11.cc b/ui/events/devices/x11/touch_factory_x11.cc

index 4201fa04bf3bdc35136b8400ab443280a7210df9..ffd8c3efa74d505dd6c655fc42768d0ef85f39c9 100644

--- a/ui/events/devices/x11/touch_factory_x11.cc

+++ b/ui/events/devices/x11/touch_factory_x11.cc

@@ -160,7 +160,8 @@ bool TouchFactory::ShouldProcessXI2Event(XEvent* xev) {

if (event->evtype == XI_TouchBegin ||

event->evtype == XI_TouchUpdate ||

event->evtype == XI_TouchEnd) {

- return !touch_events_disabled_ && IsTouchDevice(xiev->deviceid);

+ return !touch_events_disabled_ &&

+ IsTouchDevice(xiev->deviceid) && (xiev->sourceid == xiev->deviceid);

sadrul 2015/03/04 06:02:29 Add a comment here explaining the sourceid == devi

lanwei 2015/03/04 15:46:06 Done.

}

// Make sure only key-events from the virtual core keyboard are processed.

« no previous file with comments | « no previous file | ui/views/widget/desktop_aura/x11_pointer_grab.cc » ('j') | no next file with comments »