Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: test/codegen_test.dart

Issue 968273002: Fixing layout in js output (use full paths rather than just the library name) (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: address review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen/expect/typed_data/typed_data.js ('k') | test/sunflower/sunflower.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/codegen_test.dart
diff --git a/test/codegen_test.dart b/test/codegen_test.dart
index 2b8c6a90c394047411258eaf27ccd0dbcfe1bab2..f04cc02953e20c5b8adfd6716cd16ec317dab17d 100644
--- a/test/codegen_test.dart
+++ b/test/codegen_test.dart
@@ -85,9 +85,11 @@ main(arguments) {
new File(path.join(actualDir, '$filename.txt'))
.writeAsStringSync(compilerMessages.toString());
- var outputDir = new Directory(path.join(actualDir, filename));
- expect(outputDir.existsSync(), success,
- reason: '${outputDir.path} was created iff compilation succeeds');
+ var outFile = dartGen
+ ? new File(path.join(actualDir, '$filename/$filename.dart'))
+ : new File(path.join(actualDir, '$filename.js'));
+ expect(outFile.existsSync(), success,
+ reason: '${outFile.path} was created iff compilation succeeds');
// TODO(jmesserly): ideally we'd diff the output here. For now it
// happens in the containing shell script.
@@ -127,9 +129,11 @@ main(arguments) {
: path.join(testDir, 'generated_sdk');
var testSdk = new TypeResolver.fromDir(sdkPath, options);
compile('dart:core', testSdk, options);
- var outputDir = new Directory(path.join(actualDir, 'core'));
- expect(outputDir.existsSync(), true,
- reason: '${outputDir.path} was created for dart:core');
+ var outFile = dartGen
+ ? new File(path.join(actualDir, 'core/core'))
+ : new File(path.join(actualDir, 'dart/core.js'));
+ expect(outFile.existsSync(), true,
+ reason: '${outFile.path} was created for dart:core');
});
});
« no previous file with comments | « test/codegen/expect/typed_data/typed_data.js ('k') | test/sunflower/sunflower.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698